NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

domcaps: Add function for initializing domain caps as unsupported

Browse Source 
For future extensions of the domain caps it's useful to have a single
point that initializes all capabilities as unsupported by a driver. The
driver then can enable specific ones.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2019-11-13 16:10:45 +01:00
parent f2316d8d26
commit 5751a0b6b1
5 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/bhyve/bhyve_capabilities.c
View File

@ -116,9 +116,7 @@ virBhyveDomainCapsFill(virDomainCapsPtr caps,
} }
caps->hostdev.supported = VIR_TRISTATE_BOOL_NO; caps->hostdev.supported = VIR_TRISTATE_BOOL_NO;
caps->iothreads = VIR_TRISTATE_BOOL_NO; virDomainCapsFeaturesInitUnsupported(caps);
caps->vmcoreinfo = VIR_TRISTATE_BOOL_NO;
caps->genid = VIR_TRISTATE_BOOL_NO;
caps->gic.supported = VIR_TRISTATE_BOOL_NO; caps->gic.supported = VIR_TRISTATE_BOOL_NO;
return 0; return 0;

14
src/conf/domain_capabilities.c
View File

@ -309,6 +309,20 @@ virDomainCapsEnumClear(virDomainCapsEnumPtr capsEnum)
} }
/**
* @caps: domain caps
*
* Initializes all features in 'caps' as unsupported.
*/
void
virDomainCapsFeaturesInitUnsupported(virDomainCapsPtr caps)
{
caps->iothreads = VIR_TRISTATE_BOOL_NO;
caps->vmcoreinfo = VIR_TRISTATE_BOOL_NO;
caps->genid = VIR_TRISTATE_BOOL_NO;
}
static int static int
virDomainCapsEnumFormat(virBufferPtr buf, virDomainCapsEnumFormat(virBufferPtr buf,
const virDomainCapsEnum *capsEnum, const virDomainCapsEnum *capsEnum,

2
src/conf/domain_capabilities.h
View File

@ -225,6 +225,8 @@ int virDomainCapsEnumSet(virDomainCapsEnumPtr capsEnum,
unsigned int *values); unsigned int *values);
void virDomainCapsEnumClear(virDomainCapsEnumPtr capsEnum); void virDomainCapsEnumClear(virDomainCapsEnumPtr capsEnum);
void virDomainCapsFeaturesInitUnsupported(virDomainCapsPtr caps);
char * virDomainCapsFormat(const virDomainCaps *caps); char * virDomainCapsFormat(const virDomainCaps *caps);
int virDomainCapsDeviceDefValidate(const virDomainCaps *caps, int virDomainCapsDeviceDefValidate(const virDomainCaps *caps,

1
src/libvirt_private.syms
View File

@ -202,6 +202,7 @@ virDomainCapsCPUUsableTypeToString;
virDomainCapsDeviceDefValidate; virDomainCapsDeviceDefValidate;
virDomainCapsEnumClear; virDomainCapsEnumClear;
virDomainCapsEnumSet; virDomainCapsEnumSet;
virDomainCapsFeaturesInitUnsupported;
virDomainCapsFormat; virDomainCapsFormat;
virDomainCapsNew; virDomainCapsNew;
virSEVCapabilitiesFree; virSEVCapabilitiesFree;

5
src/libxl/libxl_capabilities.c
View File

@ -764,9 +764,8 @@ libxlMakeDomainCapabilities(virDomainCapsPtr domCaps,
libxlMakeDomainDeviceHostdevCaps(hostdev) < 0) libxlMakeDomainDeviceHostdevCaps(hostdev) < 0)
return -1; return -1;
domCaps->iothreads = VIR_TRISTATE_BOOL_NO; virDomainCapsFeaturesInitUnsupported(domCaps);
domCaps->vmcoreinfo = VIR_TRISTATE_BOOL_NO;
domCaps->genid = VIR_TRISTATE_BOOL_NO;
domCaps->gic.supported = VIR_TRISTATE_BOOL_NO; domCaps->gic.supported = VIR_TRISTATE_BOOL_NO;
return 0; return 0;