NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

qemu_process: add tray changed event to queue in refresh disks

Browse Source 
There are some cases when the internal state of disks can change
without qemu sending events about it (e.g. a disk can close
during reset). In case this happens, we should emit an event
about the modified disk.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1824722#c20

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Kristina Hanicova 2022-12-13 13:40:26 +01:00 committed by Michal Privoznik
parent e6cd8b6eb3
commit 5ef2582646
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/qemu/qemu_process.c
View File

@ -8673,6 +8673,7 @@ qemuProcessRefreshDisks(virDomainObj *vm,
virDomainAsyncJob asyncJob) virDomainAsyncJob asyncJob)
{ {
qemuDomainObjPrivate *priv = vm->privateData; qemuDomainObjPrivate *priv = vm->privateData;
virQEMUDriver *driver = priv->driver;
g_autoptr(GHashTable) table = NULL; g_autoptr(GHashTable) table = NULL;
size_t i; size_t i;
@ -8697,14 +8698,26 @@ qemuProcessRefreshDisks(virDomainObj *vm,
continue; continue;
if (info->removable) { if (info->removable) {
virObjectEvent *event = NULL;
int reason;
if (info->empty) if (info->empty)
virDomainDiskEmptySource(disk); virDomainDiskEmptySource(disk);
if (info->tray) { if (info->tray) {
if (info->tray_open) if (info->tray_open == disk->tray_status)
continue;
if (info->tray_open) {
reason = VIR_DOMAIN_EVENT_TRAY_CHANGE_OPEN;
disk->tray_status = VIR_DOMAIN_DISK_TRAY_OPEN; disk->tray_status = VIR_DOMAIN_DISK_TRAY_OPEN;
else } else {
reason = VIR_DOMAIN_EVENT_TRAY_CHANGE_CLOSE;
disk->tray_status = VIR_DOMAIN_DISK_TRAY_CLOSED; disk->tray_status = VIR_DOMAIN_DISK_TRAY_CLOSED;
}
event = virDomainEventTrayChangeNewFromObj(vm, disk->info.alias, reason);
virObjectEventStateQueue(driver->domainEventState, event);
} }
} }