mirror of
https://github.com/libvirt/libvirt.git
synced 2026-08-13 06:34:42 -05:00
qemu: revert latest pSeries NVDIMM design changes
In [1], changes were made to remove the existing auto-alignment for pSeries NVDIMM devices. That design promotes strange situations where the NVDIMM size reported in the domain XML is different from what QEMU is actually using. We removed the auto-alignment and relied on standard size validation. However, this goes against Libvirt design philosophy of not tampering with existing guest behavior, as pointed out by Daniel in [2]. Since we can't know for sure whether there are guests that are relying on the auto-alignment feature to work, the changes made in [1] are a direct violation of this rule. This patch reverts [1] entirely, re-enabling auto-alignment for pSeries NVDIMM as it was before. Changes will be made to ease the limitations of this design without hurting existing guests. This reverts the following commits: - commit2d93cbdea9Revert "formatdomain.html.in: mention pSeries NVDIMM 'align down' mechanic" - commit0ee56369c8qemu_domain.c: change qemuDomainMemoryDeviceAlignSize() return type - commit07de813924qemu_domain.c: do not auto-align ppc64 NVDIMMs - commit0ccceaa57cqemu_validate.c: add pSeries NVDIMM size alignment validation - commit4fa2202d88qemu_domain.c: make qemuDomainGetMemorySizeAlignment() public [1] https://www.redhat.com/archives/libvir-list/2020-July/msg02010.html [2] https://www.redhat.com/archives/libvir-list/2020-September/msg00572.html Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
committed by
Andrea Bolognani
parent
faf76dd70e
commit
63af8fdeb2
@@ -38,7 +38,7 @@
|
||||
<path>/tmp/nvdimm</path>
|
||||
</source>
|
||||
<target>
|
||||
<size unit='KiB'>786560</size>
|
||||
<size unit='KiB'>550000</size>
|
||||
<node>0</node>
|
||||
<label>
|
||||
<size unit='KiB'>128</size>
|
||||
|
||||
Reference in New Issue
Block a user