From 643b5f843d0689f0d230dbc08f87d8e26db54dd7 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Mon, 2 Dec 2013 14:47:09 -0500 Subject: [PATCH] virnetserverclient: Remove Coverity DEADCODE warning The x509dname is only set inside a WITH_GNUTLS conditional, so when used/check later on for NULL, Coverity detects this is not possible. Added WITH_GNUTLS around uses to remove message --- src/rpc/virnetserverclient.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 0b9ab52fe1..8acf9147f3 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -658,7 +658,9 @@ virNetServerClientCreateIdentity(virNetServerClientPtr client) #if WITH_SASL char *saslname = NULL; #endif +#if WITH_GNUTLS char *x509dname = NULL; +#endif char *seccontext = NULL; virIdentityPtr ret = NULL; @@ -748,11 +750,13 @@ virNetServerClientCreateIdentity(virNetServerClientPtr client) saslname) < 0) goto error; #endif +#if WITH_GNUTLS if (x509dname && virIdentitySetAttr(ret, VIR_IDENTITY_ATTR_X509_DISTINGUISHED_NAME, x509dname) < 0) goto error; +#endif if (seccontext && virIdentitySetAttr(ret, VIR_IDENTITY_ATTR_SELINUX_CONTEXT, @@ -770,7 +774,9 @@ cleanup: #if HAVE_SASL VIR_FREE(saslname); #endif +#if WITH_GNUTLS VIR_FREE(x509dname); +#endif return ret; error: