From 6512d09cf884fe2e3c6d665e64cc9f87e3f1ea22 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Wed, 20 Jan 2010 14:53:30 +0000 Subject: [PATCH] Fix off-by-1 in SCSI drive hotplug The loop looking for the controller associated with a SCI drive had an off by one, causing it to miss the last controller. * src/qemu/qemu_driver.c: Fix off-by-1 in searching for SCSI drive hotplug --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6ee3aef6f0..370b7ff593 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5345,7 +5345,7 @@ static int qemudDomainAttachSCSIDisk(virConnectPtr conn, goto error; } - for (i = 0 ; i < disk->info.addr.drive.controller ; i++) { + for (i = 0 ; i <= disk->info.addr.drive.controller ; i++) { cont = qemuDomainFindOrCreateSCSIDiskController(conn, driver, vm, i); if (!cont) goto error;