From 6d7a16361b54d1ea8cb0ae15a4d4d90a6f282ce0 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Mon, 23 Aug 2021 14:08:10 +0200 Subject: [PATCH] virsh-snapshot: Don't leak @then in cmdSnapshotList() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The variable is used inside a loop in which it's allocated in each iteration. Bring it inside the loop so that g_autoptr() kicks in each iteration. Fixes: 3caa28dc50df7ec215713075d669b20bef6473a2 Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- tools/virsh-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index ee99d0e061..e08ecb6910 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1439,7 +1439,6 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd) size_t i; virDomainSnapshotPtr snapshot = NULL; long long creation_longlong; - g_autoptr(GDateTime) then = NULL; bool tree = vshCommandOptBool(cmd, "tree"); bool name = vshCommandOptBool(cmd, "name"); bool from = vshCommandOptBool(cmd, "from"); @@ -1533,6 +1532,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd) } for (i = 0; i < snaplist->nsnaps; i++) { + g_autoptr(GDateTime) then = NULL; g_autofree gchar *thenstr = NULL; g_autoptr(xmlDoc) xml = NULL; g_autoptr(xmlXPathContext) ctxt = NULL;