NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

conf: Keep 'readonly' property when resetting disk source

Browse Source 
The property is necessary also for the disk using the source (e.g. cdrom)
which needs to be kept readonly.

Commit '462c4b66' was a bit too aggressive in this aspect, since the
readonly flag is set only while parsing.
This commit is contained in:
Peter Krempa 2017-04-07 13:44:54 +02:00
parent b003b9781b
commit 7526a71586
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/domain_conf.c
View File

@ -1723,9 +1723,12 @@ void
virDomainDiskEmptySource(virDomainDiskDefPtr def) virDomainDiskEmptySource(virDomainDiskDefPtr def)
{ {
virStorageSourcePtr src = def->src; virStorageSourcePtr src = def->src;
bool readonly = src->readonly;
virStorageSourceClear(src); virStorageSourceClear(src);
src->type = VIR_STORAGE_TYPE_FILE; src->type = VIR_STORAGE_TYPE_FILE;
/* readonly property is necessary for CDROMs and thus can't be cleared */
src->readonly = readonly;
} }