From 762c7822b952f52b15516316f98e8a7cb356fbd5 Mon Sep 17 00:00:00 2001 From: Tim Wiederhake Date: Tue, 4 May 2021 16:02:29 +0200 Subject: [PATCH] virDomainVcpuPinDefParseXML: Use virXMLProp* Signed-off-by: Tim Wiederhake Reviewed-by: Michal Privoznik --- src/conf/domain_conf.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c25b5ad19f..f729de7e76 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17089,17 +17089,8 @@ virDomainVcpuPinDefParseXML(virDomainDef *def, unsigned int vcpuid; g_autofree char *tmp = NULL; - if (!(tmp = virXMLPropString(node, "vcpu"))) { - virReportError(VIR_ERR_XML_ERROR, "%s", _("missing vcpu id in vcpupin")); + if (virXMLPropUInt(node, "vcpu", 10, VIR_XML_PROP_REQUIRED, &vcpuid) < 0) return -1; - } - - if (virStrToLong_uip(tmp, NULL, 10, &vcpuid) < 0) { - virReportError(VIR_ERR_XML_ERROR, - _("invalid setting for vcpu '%s'"), tmp); - return -1; - } - VIR_FREE(tmp); if (!(vcpu = virDomainDefGetVcpu(def, vcpuid))) { VIR_WARN("Ignoring vcpupin for missing vcpus");