From 763941749eaa206d5c66e87e59c967814cbd6a27 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Wed, 6 Jan 2016 16:07:42 +0100 Subject: [PATCH] conf: disallow empty cpuset for emulatorpin It's disallowed in the API. --- src/conf/domain_conf.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 68287f3d7d..1ea74a6ad6 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -14275,8 +14275,18 @@ virDomainEmulatorPinDefParseXML(xmlNodePtr node) return NULL; } - ignore_value(virBitmapParse(tmp, 0, &def, VIR_DOMAIN_CPUMASK_LEN)); + if (virBitmapParse(tmp, 0, &def, VIR_DOMAIN_CPUMASK_LEN) < 0) + goto cleanup; + if (virBitmapIsAllClear(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Invalid value of 'cpuset': %s"), tmp); + virBitmapFree(def); + def = NULL; + goto cleanup; + } + + cleanup: VIR_FREE(tmp); return def; }