From 77570e2600d2f4ac62b9dc0af190bf05c0f9c6b4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Tue, 16 Jul 2019 10:37:03 +0200 Subject: [PATCH] qemu: command: use VIR_AUTOFREE in qemuBuildFSDevCommandLine MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Introduce two separate variables instead of reusing the same one for clarity. Signed-off-by: Ján Tomko Acked-by: Peter Krempa --- src/qemu/qemu_command.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 02a6642207..ef90dc5044 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2807,22 +2807,21 @@ qemuBuildFSDevCommandLine(virCommandPtr cmd, const virDomainDef *def, virQEMUCapsPtr qemuCaps) { - char *optstr; + VIR_AUTOFREE(char *) fsdevstr = NULL; + VIR_AUTOFREE(char *) devicestr = NULL; virCommandAddArg(cmd, "-fsdev"); - if (!(optstr = qemuBuildFSStr(fs))) + if (!(fsdevstr = qemuBuildFSStr(fs))) return -1; - virCommandAddArg(cmd, optstr); - VIR_FREE(optstr); + virCommandAddArg(cmd, fsdevstr); if (qemuCommandAddExtDevice(cmd, &fs->info) < 0) return -1; virCommandAddArg(cmd, "-device"); - if (!(optstr = qemuBuildFSDevStr(def, fs, qemuCaps))) + if (!(devicestr = qemuBuildFSDevStr(def, fs, qemuCaps))) return -1; - virCommandAddArg(cmd, optstr); - VIR_FREE(optstr); + virCommandAddArg(cmd, devicestr); return 0; }