NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

virStorageSourceParseBackingJSONUriCookies: Use g_strsplit instead of virStringSplitCount

Browse Source 
Count the elements after splitting the string.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2021-03-23 09:12:19 +01:00
parent def579e88a
commit 7f5c2ad88f
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/storage_file/storage_source_backingstore.c
View File

@ -483,7 +483,6 @@ virStorageSourceParseBackingJSONUriCookies(virStorageSourcePtr src,
{ {
const char *cookiestr; const char *cookiestr;
g_auto(GStrv) cookies = NULL; g_auto(GStrv) cookies = NULL;
size_t ncookies = 0;
size_t i; size_t i;
if (!virJSONValueObjectHasKey(json, "cookie")) if (!virJSONValueObjectHasKey(json, "cookie"))
@ -496,13 +495,13 @@ virStorageSourceParseBackingJSONUriCookies(virStorageSourcePtr src,
return -1; return -1;
} }
if (!(cookies = virStringSplitCount(cookiestr, ";", 0, &ncookies))) if (!(cookies = g_strsplit(cookiestr, ";", 0)))
return -1; return -1;
src->cookies = g_new0(virStorageNetCookieDefPtr, ncookies); src->ncookies = g_strv_length(cookies);
src->ncookies = ncookies; src->cookies = g_new0(virStorageNetCookieDefPtr, src->ncookies);
for (i = 0; i < ncookies; i++) { for (i = 0; i < src->ncookies; i++) {
char *cookiename = cookies[i]; char *cookiename = cookies[i];
char *cookievalue; char *cookievalue;