NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Resolve Coverity NEGATIVE_RETURNS

Browse Source 
Coverity notes that if the virConnectListAllDomains returns a negative
value then the loop at the cleanup label that ends on numDomains will
have issues.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2014-09-04 17:18:48 -04:00
parent b74a3fb307
commit 81a8fc34ad
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_driver.c
View File

@ -1004,9 +1004,11 @@ qemuStateStop(void)
ret = -1; ret = -1;
cleanup: cleanup:
if (domains) {
for (i = 0; i < numDomains; i++) for (i = 0; i < numDomains; i++)
virDomainFree(domains[i]); virDomainFree(domains[i]);
VIR_FREE(domains); VIR_FREE(domains);
}
VIR_FREE(flags); VIR_FREE(flags);
virObjectUnref(conn); virObjectUnref(conn);
virObjectUnref(cfg); virObjectUnref(cfg);