domain_conf: make virDomainChrSourceDefFormat() void

This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Matt Coleman 2020-11-05 22:32:53 -05:00 committed by Michal Privoznik
parent 10ad796901
commit 82966a0104

View File

@ -27185,7 +27185,7 @@ virDomainChrAttrsDefFormat(virBufferPtr buf,
return 0; return 0;
} }
static int static void
virDomainChrSourceDefFormat(virBufferPtr buf, virDomainChrSourceDefFormat(virBufferPtr buf,
virDomainChrSourceDefPtr def, virDomainChrSourceDefPtr def,
unsigned int flags) unsigned int flags)
@ -27298,8 +27298,6 @@ virDomainChrSourceDefFormat(virBufferPtr buf,
} }
virBufferAddLit(buf, "/>\n"); virBufferAddLit(buf, "/>\n");
} }
return 0;
} }
@ -27446,8 +27444,7 @@ virDomainChrDefFormat(virBufferPtr buf,
return -1; return -1;
virBufferAddLit(buf, ">\n"); virBufferAddLit(buf, ">\n");
if (virDomainChrSourceDefFormat(buf, def->source, flags) < 0) virDomainChrSourceDefFormat(buf, def->source, flags);
return -1;
if (virDomainChrTargetDefFormat(buf, def, flags) < 0) if (virDomainChrTargetDefFormat(buf, def, flags) < 0)
return -1; return -1;
@ -27489,8 +27486,7 @@ virDomainSmartcardDefFormat(virBufferPtr buf,
break; break;
case VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH: case VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH:
if (virDomainChrSourceDefFormat(&childBuf, def->data.passthru, flags) < 0) virDomainChrSourceDefFormat(&childBuf, def->data.passthru, flags);
return -1;
break; break;
default: default:
@ -27829,8 +27825,7 @@ virDomainRNGDefFormat(virBufferPtr buf,
return -1; return -1;
virBufferAddLit(buf, ">\n"); virBufferAddLit(buf, ">\n");
virBufferAdjustIndent(buf, 2); virBufferAdjustIndent(buf, 2);
if (virDomainChrSourceDefFormat(buf, def->source.chardev, flags) < 0) virDomainChrSourceDefFormat(buf, def->source.chardev, flags);
return -1;
virBufferAdjustIndent(buf, -2); virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "</backend>\n"); virBufferAddLit(buf, "</backend>\n");
break; break;
@ -28767,8 +28762,7 @@ virDomainRedirdevDefFormat(virBufferPtr buf,
virBufferAddLit(buf, ">\n"); virBufferAddLit(buf, ">\n");
virBufferAdjustIndent(buf, 2); virBufferAdjustIndent(buf, 2);
if (virDomainChrSourceDefFormat(buf, def->source, flags) < 0) virDomainChrSourceDefFormat(buf, def->source, flags);
return -1;
virDomainDeviceInfoFormat(buf, &def->info, flags | VIR_DOMAIN_DEF_FORMAT_ALLOW_BOOT); virDomainDeviceInfoFormat(buf, &def->info, flags | VIR_DOMAIN_DEF_FORMAT_ALLOW_BOOT);
virBufferAdjustIndent(buf, -2); virBufferAdjustIndent(buf, -2);