From 8833b42f3b092c1b401109ddf174ea1dbb1eb8c6 Mon Sep 17 00:00:00 2001 From: Scott Davis Date: Wed, 25 May 2022 18:20:40 -0400 Subject: [PATCH] vircgroupv1: fix null string specifier argument in virCgroupV1ValidatePlacement MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Detected by gcc 11 -Wformat-overflow: ../../src/util/vircgroupv1.c: In function ‘virCgroupV1ValidatePlacement’: ../../src/util/virerror.h:176:5: warning: ‘%s’ directive argument is null [-Wformat-overflow=] 176 | virReportErrorHelper(VIR_FROM_THIS, code, __FILE__, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 177 | __FUNCTION__, __LINE__, __VA_ARGS__) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../src/util/vircgroupv1.c:411:13: note: in expansion of macro ‘virReportError’ 411 | virReportError(VIR_ERR_INTERNAL_ERROR, | ^~~~~~~~~~~~~~ ../../src/util/vircgroupv1.c:412:80: note: format string is defined here 412 | _("Could not find placement for v1 controller %s at %s"), | ^~ Signed-off-by: Scott Davis Reviewed-by: Ján Tomko --- src/util/vircgroupv1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c index 96f36c3b4d..cbee08e931 100644 --- a/src/util/vircgroupv1.c +++ b/src/util/vircgroupv1.c @@ -409,9 +409,8 @@ virCgroupV1ValidatePlacement(virCgroup *group, if (!group->legacy[i].placement) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Could not find placement for v1 controller %s at %s"), - virCgroupV1ControllerTypeToString(i), - group->legacy[i].placement); + _("Could not find placement for v1 controller %s"), + virCgroupV1ControllerTypeToString(i)); return -1; }