From 8c49e04ecd0e442389b029004a0f0bc3e958a6eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= Date: Thu, 12 Apr 2018 03:03:21 +0200 Subject: [PATCH] libxl: warn about ignored CPU mode=custom MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When support for mode=custom will be added in the future, semantics of current config will change. Reduce the surprise by emitting a warning. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Daniel P. Berrangé --- src/libxl/libxl_conf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 2565f6473c..2053ed3327 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -424,6 +424,12 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_defbool_set(&b_info->u.hvm.nested_hvm, hasHwVirt); } + if (def->cpu && def->cpu->mode == VIR_CPU_MODE_CUSTOM) { + VIR_WARN("Ignoring CPU with mode=custom, update your config to " + "mode=host-passthrough to avoid risk of changed guest " + "semantics when mode=custom is supported in the future"); + } + if (def->nsounds > 0) { /* * Use first sound device. man xl.cfg(5) describes soundhw as