From 8f95d5d84c0387b9c52ff2d2b557e093e02e0481 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 1 Aug 2013 16:33:23 +0200 Subject: [PATCH] qemumonitortestutils: Don't skip va_end() on error path When allocation of memory failed the error path didn't call va_end() causing a coverity failure. Reported by John Ferlan. --- tests/qemumonitortestutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index fb76156a57..5697946459 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -669,7 +669,7 @@ qemuMonitorTestAddItemParams(qemuMonitorTestPtr test, va_start(args, response); if (VIR_ALLOC(data) < 0) - return -1; + goto error; if (VIR_STRDUP(data->command_name, cmdname) < 0 || VIR_STRDUP(data->response, response) < 0)