NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

qemu_tpm.c: fix 'shortName' leak

Browse Source 
This is a Coverity fix pointed out by John in IRC. This code
was introduced in 19d74fdf0e, when the TPM Proxy device for
for ppc64 was introduced.

This will leak in case we have 2 TPMs in the same domain, a
possible scenario with the protected Ultravisor execution in
PowerPC guests.

Fixes: 19d74fdf0e
Reported-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
Daniel Henrique Barboza 2020-11-14 09:56:41 -03:00
parent e8e90a35df
commit 904e59f43a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_tpm.c
View File

@ -841,10 +841,11 @@ qemuExtTPMStop(virQEMUDriverPtr driver,
virDomainObjPtr vm) virDomainObjPtr vm)
{ {
g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
g_autofree char *shortName = NULL;
size_t i; size_t i;
for (i = 0; i < vm->def->ntpms; i++) { for (i = 0; i < vm->def->ntpms; i++) {
g_autofree char *shortName = NULL;
if (vm->def->tpms[i]->type != VIR_DOMAIN_TPM_TYPE_EMULATOR) if (vm->def->tpms[i]->type != VIR_DOMAIN_TPM_TYPE_EMULATOR)
continue; continue;
@ -866,12 +867,13 @@ qemuExtTPMSetupCgroup(virQEMUDriverPtr driver,
virCgroupPtr cgroup) virCgroupPtr cgroup)
{ {
g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver);
g_autofree char *shortName = NULL;
int rc; int rc;
pid_t pid; pid_t pid;
size_t i; size_t i;
for (i = 0; i < def->ntpms; i++) { for (i = 0; i < def->ntpms; i++) {
g_autofree char *shortName = NULL;
if (def->tpms[i]->type != VIR_DOMAIN_TPM_TYPE_EMULATOR) if (def->tpms[i]->type != VIR_DOMAIN_TPM_TYPE_EMULATOR)
continue; continue;