NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

leaseshelper: move comment about adding IPv6 leases

Browse Source 
The comment is relevant to the ADD action, not DEL.
This commit is contained in:
Ján Tomko
2016-01-20 09:34:47 +01:00
parent 21fb379549
commit 99569948d3
1 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/network/leaseshelper.c
View File

@@ -401,6 +401,19 @@ main(int argc, char **argv)
switch ((enum virLeaseActionFlags) action) { switch ((enum virLeaseActionFlags) action) {
case VIR_LEASE_ACTION_ADD: case VIR_LEASE_ACTION_ADD:
case VIR_LEASE_ACTION_OLD: case VIR_LEASE_ACTION_OLD:
/* Custom ipv6 leases *will not* be created if the env-var DNSMASQ_MAC
* is not set. In the special case, when the $(interface).status file
* is not already present and dnsmasq is (re)started, the corresponding
* ipv6 custom lease will be created only when the guest sends the
* 'old' action for its existing ipv6 interfaces.
*
* According to rfc3315, the combination of DUID and IAID can be used
* to uniquely identify each ipv6 guest interface. So, in future, if
* we introduce virNetworkGetDHCPLeaseBy(IAID|DUID|IAID+DUID) for ipv6
* interfaces, then, the following if condition won't be required, as
* the new lease will be created irrespective of whether the MACID is
* known or not.
*/
if (!mac) if (!mac)
break; break;
delete = true; delete = true;
@@ -439,19 +452,6 @@ main(int argc, char **argv)
case VIR_LEASE_ACTION_DEL: case VIR_LEASE_ACTION_DEL:
delete = true; delete = true;
/* Custom ipv6 leases *will not* be created if the env-var DNSMASQ_MAC
* is not set. In the special case, when the $(interface).status file
* is not already present and dnsmasq is (re)started, the corresponding
* ipv6 custom lease will be created only when the guest sends the
* 'old' action for its existing ipv6 interfaces.
*
* According to rfc3315, the combination of DUID and IAID can be used
* to uniquely identify each ipv6 guest interface. So, in future, if
* we introduce virNetworkGetDHCPLeaseBy(IAID|DUID|IAID+DUID) for ipv6
* interfaces, then, the following if condition won't be required, as
* the new lease will be created irrespective of whether the MACID is
* known or not.
*/
if (mac) { if (mac) {
/* Delete the corresponding lease, if it already exists */ /* Delete the corresponding lease, if it already exists */
delete = true; delete = true;