NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix leak on OOM in virNWFilterVarValueCreateSimpleCopyValue

Browse Source 
If virNWFilterVarValueCreateSimple fails with OOM, then
'val' will be leaked by virNWFilterVarValueCreateSimpleCopyValue

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2014-04-08 15:43:45 +01:00
parent dff3ad004a
commit 9b095625e4
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/conf/nwfilter_params.c
View File

@ -126,10 +126,14 @@ virNWFilterVarValuePtr
virNWFilterVarValueCreateSimpleCopyValue(const char *value) virNWFilterVarValueCreateSimpleCopyValue(const char *value)
{ {
char *val; char *val;
virNWFilterVarValuePtr ret;
if (VIR_STRDUP(val, value) < 0) if (VIR_STRDUP(val, value) < 0)
return NULL; return NULL;
return virNWFilterVarValueCreateSimple(val); ret = virNWFilterVarValueCreateSimple(val);
if (!ret)
VIR_FREE(val);
return ret;
} }
const char * const char *