mirror of
https://github.com/libvirt/libvirt.git
synced 2025-02-25 18:55:26 -06:00
Require K&R styled curly braces around function bodies
Although not explicitly requested, we are using K&R (or Kernel) indentation for curly braces around functions in HACKING file and most of the code. Using grep -P, this patch add the syntax-check rule for it (while skipping all the false positives with foreach constructs). Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
parent
95aed7febc
commit
9b7ac663ee
7
cfg.mk
7
cfg.mk
@ -898,6 +898,13 @@ sc_prohibit_virConnectOpen_in_virsh:
|
|||||||
halt='Use vshConnect() in virsh instead of virConnectOpen*' \
|
halt='Use vshConnect() in virsh instead of virConnectOpen*' \
|
||||||
$(_sc_search_regexp)
|
$(_sc_search_regexp)
|
||||||
|
|
||||||
|
sc_curly_braces_style:
|
||||||
|
@files=$$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); \
|
||||||
|
$(GREP) -nHP \
|
||||||
|
'^\s*(?!([a-zA-Z_]*for_?each[a-zA-Z_]*) ?\()([_a-zA-Z0-9]+( [_a-zA-Z0-9]+)* ?\()?(\*?[_a-zA-Z0-9]+(,? \*?[_a-zA-Z0-9\[\]]+)+|void)\) ?\{' \
|
||||||
|
$$files && { echo '$(ME): Non-K&R style used for curly' \
|
||||||
|
'braces around function body, see' \
|
||||||
|
'HACKING' 1>&2; exit 1; } || :
|
||||||
|
|
||||||
# We don't use this feature of maint.mk.
|
# We don't use this feature of maint.mk.
|
||||||
prev_version_file = /dev/null
|
prev_version_file = /dev/null
|
||||||
|
Loading…
Reference in New Issue
Block a user