NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

libxl: fix leaking libxl events

Browse Source 
libxl expects the event handler to free the event passed to it.  From
libxl_event.h:

   event becomes owned by the application and must be freed, either
   by event_occurs or later
This commit is contained in:
Jim Fehlig 2013-05-16 09:38:56 -06:00
parent 43b0ff5b1e
commit a2619bb1ff
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libxl/libxl_driver.c
View File

@ -711,10 +711,10 @@ libxlVmReap(libxlDriverPrivatePtr driver,
#endif #endif
static void static void
libxlEventHandler(void *data ATTRIBUTE_UNUSED, libxlEventHandler(void *data, VIR_LIBXL_EVENT_CONST libxl_event *event)
VIR_LIBXL_EVENT_CONST libxl_event *event)
{ {
libxlDriverPrivatePtr driver = libxl_driver; libxlDriverPrivatePtr driver = libxl_driver;
libxlDomainObjPrivatePtr priv = ((virDomainObjPtr)data)->privateData;
virDomainObjPtr vm = NULL; virDomainObjPtr vm = NULL;
virDomainEventPtr dom_event = NULL; virDomainEventPtr dom_event = NULL;
libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason; libxl_shutdown_reason xl_reason = event->u.domain_shutdown.shutdown_reason;
@ -771,6 +771,8 @@ cleanup:
libxlDomainEventQueue(driver, dom_event); libxlDomainEventQueue(driver, dom_event);
libxlDriverUnlock(driver); libxlDriverUnlock(driver);
} }
/* Cast away any const */
libxl_event_free(priv->ctx, (libxl_event *)event);
} }
static const struct libxl_event_hooks ev_hooks = { static const struct libxl_event_hooks ev_hooks = {