NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

examples/dommigrate: Make retval portable

Browse Source 
Currently, the dommigrate example returns 0 or 1 for success or
failure state, respectively. Except for a few cases where it
forgot to change the @ret variable just before jumping onto the
'cleanup' label. Making the code follow our usual pattern
(initialize @ret to an error value and set it to success value
only at the end) fixes those cases. Also, using EXIT_SUCCESS and
EXIT_FAILURE is more portable (even though on my system they are
just an alias to values the example already uses).

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Kristína Hanicová <khanicov@redhat.com>
This commit is contained in:
Michal Privoznik 2021-11-08 13:33:09 +01:00
parent 132069f845
commit a4056d52eb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/c/domain/dommigrate.c
View File

@ -36,7 +36,7 @@ int
main(int argc, char *argv[]) main(int argc, char *argv[])
{ {
char *src_uri, *dst_uri, *domname; char *src_uri, *dst_uri, *domname;
int ret = 0; int ret = EXIT_FAILURE;
virConnectPtr conn = NULL; virConnectPtr conn = NULL;
virDomainPtr dom = NULL; virDomainPtr dom = NULL;
@ -52,7 +52,6 @@ main(int argc, char *argv[])
printf("Attempting to connect to the source hypervisor...\n"); printf("Attempting to connect to the source hypervisor...\n");
conn = virConnectOpenAuth(src_uri, virConnectAuthPtrDefault, 0); conn = virConnectOpenAuth(src_uri, virConnectAuthPtrDefault, 0);
if (!conn) { if (!conn) {
ret = 1;
fprintf(stderr, "No connection to the source hypervisor: %s.\n", fprintf(stderr, "No connection to the source hypervisor: %s.\n",
virGetLastErrorMessage()); virGetLastErrorMessage());
goto out; goto out;
@ -74,6 +73,7 @@ main(int argc, char *argv[])
} }
printf("Migration finished with success.\n"); printf("Migration finished with success.\n");
ret = EXIT_SUCCESS;
cleanup: cleanup:
if (dom != NULL) if (dom != NULL)