From a47e73d6e76c85b0897e3cccaf0a58ed3c367664 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Date: Tue, 7 May 2024 14:35:39 +0100 Subject: [PATCH] src/node_device: don't overwrite error messages MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The nodedev code unhelpfully reports couldn't convert node device def to mdevctl JSON which hides the actual error message No JSON parser implementation is available Reviewed-by: Peter Krempa Signed-off-by: Daniel P. Berrangé --- src/node_device/node_device_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c index d99b48138e..700776c90c 100644 --- a/src/node_device/node_device_driver.c +++ b/src/node_device/node_device_driver.c @@ -774,8 +774,6 @@ nodeDeviceGetMdevctlCommand(virNodeDeviceDef *def, } if (nodeDeviceDefToMdevctlConfig(def, &inbuf, true) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("couldn't convert node device def to mdevctl JSON")); return NULL; }