From a4b0c75ce8e221ace1eba61fe0f722dbb0a95671 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 23 Sep 2013 15:11:19 +0100 Subject: [PATCH] Add missing check for OOM when building boot menu args When building boot menu args, if OOM occurred the CLI args would end up containing 'order=(null)' due to a missing call to 'virBufferError'. Signed-off-by: Daniel P. Berrange --- src/qemu/qemu_command.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 850cceaa26..9900b411f8 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -8057,6 +8057,11 @@ qemuBuildCommandLine(virConnectPtr conn, if (boot_nparams > 0) { virCommandAddArg(cmd, "-boot"); + if (virBufferError(&boot_buf)) { + virReportOOMError(); + goto error; + } + if (boot_nparams < 2 || emitBootindex) { virCommandAddArgBuffer(cmd, &boot_buf); virBufferFreeAndReset(&boot_buf);