NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Enable use of -Wold-style-definition compiler flag

Browse Source 
A couple of functions were declared using the old style foo()
for no-parameters, instead of foo(void)

* src/xen/xen_hypervisor.c, tests/testutils.c: Replace () with (void)
  in some function declarations
* m4/virt-compile-warnings.m4: Enable -Wold-style-definition
This commit is contained in:
Daniel P. Berrange 2010-07-16 17:30:00 +01:00
parent 329e9dc629
commit a4e37ff1a3
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
m4/virt-compile-warnings.m4
View File

@ -62,7 +62,6 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
dontwarn="$dontwarn -Wcast-qual" dontwarn="$dontwarn -Wcast-qual"
dontwarn="$dontwarn -Wconversion" dontwarn="$dontwarn -Wconversion"
dontwarn="$dontwarn -Wsign-conversion" dontwarn="$dontwarn -Wsign-conversion"
dontwarn="$dontwarn -Wold-style-definition"
dontwarn="$dontwarn -Wpacked" dontwarn="$dontwarn -Wpacked"
dontwarn="$dontwarn -Wunused-macros" dontwarn="$dontwarn -Wunused-macros"
dontwarn="$dontwarn -Woverlength-strings" dontwarn="$dontwarn -Woverlength-strings"

2
src/xen/xen_hypervisor.c
View File

@ -3621,7 +3621,7 @@ xenHypervisorGetVcpuMax(virDomainPtr domain)
* Return true if the current process should be able to connect to Xen. * Return true if the current process should be able to connect to Xen.
*/ */
int int
xenHavePrivilege() xenHavePrivilege(void)
{ {
#ifdef __sun #ifdef __sun
return priv_ineffect (PRIV_XVM_CONTROL); return priv_ineffect (PRIV_XVM_CONTROL);

4
tests/testutils.c
View File

@ -457,14 +457,14 @@ virTestGetFlag(const char *name) {
} }
unsigned int unsigned int
virTestGetDebug() { virTestGetDebug(void) {
if (testDebug == -1) if (testDebug == -1)
testDebug = virTestGetFlag("VIR_TEST_DEBUG"); testDebug = virTestGetFlag("VIR_TEST_DEBUG");
return testDebug; return testDebug;
} }
unsigned int unsigned int
virTestGetVerbose() { virTestGetVerbose(void) {
if (testVerbose == -1) if (testVerbose == -1)
testVerbose = virTestGetFlag("VIR_TEST_VERBOSE"); testVerbose = virTestGetFlag("VIR_TEST_VERBOSE");
return testVerbose || virTestGetDebug(); return testVerbose || virTestGetDebug();