Add helper API for finding auth file path

* src/util/virauth.c, src/util/virauth.h: Add virAuthGetConfigFilePath
* include/libvirt/virterror.h, src/util/virterror.c: Add
  VIR_FROM_AUTH error domain

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange
2012-03-20 15:40:05 +00:00
parent 4262e34eb5
commit a4fb88b5c9
12 changed files with 577 additions and 3 deletions

View File

@@ -96,7 +96,8 @@ check_PROGRAMS = virshtest conftest sockettest \
commandtest commandhelper seclabeltest \
virhashtest virnetmessagetest virnetsockettest ssh \
utiltest virnettlscontexttest shunloadtest \
virtimetest viruritest virkeyfiletest
virtimetest viruritest virkeyfiletest \
virauthconfigtest
check_LTLIBRARIES = libshunload.la
@@ -221,6 +222,7 @@ TESTS = virshtest \
virtimetest \
viruritest \
virkeyfiletest \
virauthconfigtest \
shunloadtest \
utiltest \
$(test_scripts)
@@ -518,6 +520,11 @@ virkeyfiletest_SOURCES = \
virkeyfiletest_CFLAGS = -Dabs_builddir="\"$(abs_builddir)\"" $(AM_CFLAGS)
virkeyfiletest_LDADD = ../src/libvirt-net-rpc.la $(LDADDS)
virauthconfigtest_SOURCES = \
virauthconfigtest.c testutils.h testutils.c
virauthconfigtest_CFLAGS = -Dabs_builddir="\"$(abs_builddir)\"" $(AM_CFLAGS)
virauthconfigtest_LDADD = ../src/libvirt-net-rpc.la $(LDADDS)
seclabeltest_SOURCES = \
seclabeltest.c
seclabeltest_LDADD = ../src/libvirt_driver_security.la $(LDADDS)

140
tests/virauthconfigtest.c Normal file
View File

@@ -0,0 +1,140 @@
/*
* Copyright (C) 2012 Red Hat, Inc.
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
* version 2.1 of the License, or (at your option) any later version.
*
* This library is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this library; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
* Author: Daniel P. Berrange <berrange@redhat.com>
*/
#include <config.h>
#include <stdlib.h>
#include <signal.h>
#include "testutils.h"
#include "util.h"
#include "virterror_internal.h"
#include "memory.h"
#include "logging.h"
#include "virauthconfig.h"
#define VIR_FROM_THIS VIR_FROM_RPC
struct ConfigLookupData {
virAuthConfigPtr config;
const char *hostname;
const char *service;
const char *credname;
const char *expect;
};
static int testAuthLookup(const void *args)
{
int ret = -1;
const struct ConfigLookupData *data = args;
const char *actual = NULL;
int rv;
rv = virAuthConfigLookup(data->config,
data->service,
data->hostname,
data->credname,
&actual);
if (rv < 0)
goto cleanup;
if (data->expect) {
if (!actual ||
!STREQ(actual, data->expect)) {
VIR_WARN("Expected value '%s' for '%s' '%s' '%s', but got '%s'",
data->expect, data->hostname,
data->service, data->credname,
NULLSTR(actual));
goto cleanup;
}
} else {
if (actual) {
VIR_WARN("Did not expect a value for '%s' '%s' '%s', but got '%s'",
data->hostname,
data->service, data->credname,
actual);
goto cleanup;
}
}
ret = 0;
cleanup:
return ret;
}
static int
mymain(void)
{
int ret = 0;
virAuthConfigPtr config;
signal(SIGPIPE, SIG_IGN);
#define TEST_LOOKUP(config, hostname, service, credname, expect) \
do { \
const struct ConfigLookupData data = { \
config, hostname, service, credname, expect \
}; \
if (virtTestRun("Test Lookup " hostname "-" service "-" credname, \
1, testAuthLookup, &data) < 0) \
ret = -1; \
} while (0)
const char *confdata =
"[credentials-test]\n"
"username=fred\n"
"password=123456\n"
"\n"
"[credentials-prod]\n"
"username=bar\n"
"password=letmein\n"
"\n"
"[auth-libvirt-test1.example.com]\n"
"credentials=test\n"
"\n"
"[auth-libvirt-test2.example.com]\n"
"credentials=test\n"
"\n"
"[auth-libvirt-demo3.example.com]\n"
"credentials=test\n"
"\n"
"[auth-libvirt-prod1.example.com]\n"
"credentials=prod\n";
if (!(config = virAuthConfigNewData("auth.conf", confdata, strlen(confdata))))
return EXIT_FAILURE;
TEST_LOOKUP(config, "test1.example.com", "libvirt", "username", "fred");
TEST_LOOKUP(config, "test1.example.com", "vnc", "username", NULL);
TEST_LOOKUP(config, "test1.example.com", "libvirt", "realm", NULL);
TEST_LOOKUP(config, "test66.example.com", "libvirt", "username", NULL);
TEST_LOOKUP(config, "prod1.example.com", "libvirt", "username", "bar");
TEST_LOOKUP(config, "prod1.example.com", "libvirt", "password", "letmein");
virAuthConfigFree(config);
return (ret==0 ? EXIT_SUCCESS : EXIT_FAILURE);
}
VIRT_TEST_MAIN(mymain)