From a80957c518d311735609e39bcce384619111e531 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 12 Jan 2017 14:04:09 +0100 Subject: [PATCH] Revert "storage: Validate the device formats at logical startup" The check is pointless since LVM is capable to detect it's own members and the check is flawed as it would fail if neither libblkid nor parted is installed. We don't really need to babysit LVM in this way. This reverts commit cb38b6cbc7e35e7ee92a7f54828f21261227d17a. --- src/storage/storage_backend_logical.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 85e080bf98..6a6720e220 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -743,19 +743,6 @@ static int virStorageBackendLogicalStartPool(virConnectPtr conn ATTRIBUTE_UNUSED, virStoragePoolObjPtr pool) { - size_t i; - - /* Let's make sure the pool's devices are properly formatted */ - for (i = 0; i < pool->def->source.ndevice; i++) { - const char *path = pool->def->source.devices[i].path; - - /* The blkid FS and Part probing code doesn't know "lvm2" (this - * pool's only format type), but it does know "LVM2_member", so - * we'll pass that here */ - if (!virStorageBackendDeviceIsEmpty(path, "LVM2_member", false)) - return -1; - } - /* Let's make sure that the pool's name matches the pvs output and * that the pool's source devices match the pvs output. */