NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

conf: checkpoint: Don't require <domain> when redefining checkpoints

Browse Source 
The domain definition stored with a checkpoint isn't used currently
apart from matching disks when creating a new checkpoints.

As some users of the incremental backup API want to provide backups in
offline mode under their control (obviously while compying with our
documentation on how the on-disk state should be handled) and then want
to define the checkpoint for live use, supplying a <domain> sub-element
is overly complex and not actually needed by the code.

Relax the restriction when re-defining a checkpoint so that <domain> is
not necessary and add (alibistic) documentation saying that future
actions may not work if it's missing.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
This commit is contained in:
Peter Krempa 2020-12-02 14:18:40 +01:00
parent 392eacfeb1
commit abf12f071b
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/formatcheckpoint.rst
View File

@ -1,3 +1,5 @@
.. role:: since
Checkpoint XML format Checkpoint XML format
===================== =====================
@ -103,12 +105,16 @@ The top-level ``domaincheckpoint`` element may contain the following elements:
A readonly representation of the inactive `domain A readonly representation of the inactive `domain
configuration <formatdomain.html>`__ at the time the checkpoint was created. configuration <formatdomain.html>`__ at the time the checkpoint was created.
This element may be omitted for output brevity by supplying the This element may be omitted for output brevity by supplying the
``VIR_DOMAIN_CHECKPOINT_XML_NO_DOMAIN`` flag, but the resulting XML is no ``VIR_DOMAIN_CHECKPOINT_XML_NO_DOMAIN`` flag. The domain will have
longer viable for use with the ``VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE`` flag
of ``virDomainCheckpointCreateXML()``. The domain will have
security-sensitive information omitted unless the flag security-sensitive information omitted unless the flag
``VIR_DOMAIN_CHECKPOINT_XML_SECURE`` is provided on a read-write connection. ``VIR_DOMAIN_CHECKPOINT_XML_SECURE`` is provided on a read-write connection.
``virDomainCheckpointCreateXML()`` requires that the ``<domain>`` is present
when used with ``VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE``.
:since:`Since 7.0.0` the ``<domain>`` element can be omitted when redefining
a checkpoint, but hypervisors may not support certain operations if it's
missing.
Examples Examples
-------- --------

4
src/conf/checkpoint_conf.c
View File

@ -165,10 +165,6 @@ virDomainCheckpointDefParse(xmlXPathContextPtr ctxt,
domainParseFlags); domainParseFlags);
if (!def->parent.dom) if (!def->parent.dom)
return NULL; return NULL;
} else {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("missing domain in checkpoint redefine"));
return NULL;
} }
} else if (virDomainXMLOptionRunMomentPostParse(xmlopt, &def->parent) < 0) { } else if (virDomainXMLOptionRunMomentPostParse(xmlopt, &def->parent) < 0) {
return NULL; return NULL;