diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 525bc28962..537e515b5a 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -1105,92 +1105,81 @@ virDomainNumaDefFormatXML(virBuffer *buf, virBufferAdjustIndent(buf, 2); for (i = 0; i < ncells; i++) { virBitmap *cpumask = virDomainNumaGetNodeCpumask(def, i); - int ndistances; - size_t ncaches; + g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf); + size_t j; memAccess = virDomainNumaGetNodeMemoryAccessMode(def, i); discard = virDomainNumaGetNodeDiscard(def, i); - virBufferAddLit(buf, "mem_nodes[i].ndistances; - ncaches = def->mem_nodes[i].ncaches; - if (ndistances == 0 && ncaches == 0) { - virBufferAddLit(buf, "/>\n"); - } else { - size_t j; + if (def->mem_nodes[i].ndistances) { + virDomainNumaDistance *distances = def->mem_nodes[i].distances; - virBufferAddLit(buf, ">\n"); - virBufferAdjustIndent(buf, 2); - - if (ndistances) { - virDomainNumaDistance *distances = def->mem_nodes[i].distances; - - virBufferAddLit(buf, "\n"); - virBufferAdjustIndent(buf, 2); - for (j = 0; j < ndistances; j++) { - if (distances[j].value) { - virBufferAddLit(buf, "\n"); - } + virBufferAddLit(&childBuf, "\n"); + virBufferAdjustIndent(&childBuf, 2); + for (j = 0; j < def->mem_nodes[i].ndistances; j++) { + if (distances[j].value) { + virBufferAddLit(&childBuf, "\n"); } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); } - - for (j = 0; j < ncaches; j++) { - virDomainNumaCache *cache = &def->mem_nodes[i].caches[j]; - - virBufferAsprintf(buf, "level); - if (cache->associativity) { - virBufferAsprintf(buf, " associativity='%s'", - virDomainCacheAssociativityTypeToString(cache->associativity)); - } - - if (cache->policy) { - virBufferAsprintf(buf, " policy='%s'", - virDomainCachePolicyTypeToString(cache->policy)); - } - virBufferAddLit(buf, ">\n"); - - virBufferAdjustIndent(buf, 2); - virBufferAsprintf(buf, - "\n", - cache->size); - - if (cache->line) { - virBufferAsprintf(buf, - "\n", - cache->line); - } - - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); - } - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "\n"); + virBufferAdjustIndent(&childBuf, -2); + virBufferAddLit(&childBuf, "\n"); } + + for (j = 0; j < def->mem_nodes[i].ncaches; j++) { + virDomainNumaCache *cache = &def->mem_nodes[i].caches[j]; + + virBufferAsprintf(&childBuf, "level); + if (cache->associativity) { + virBufferAsprintf(&childBuf, " associativity='%s'", + virDomainCacheAssociativityTypeToString(cache->associativity)); + } + + if (cache->policy) { + virBufferAsprintf(&childBuf, " policy='%s'", + virDomainCachePolicyTypeToString(cache->policy)); + } + virBufferAddLit(&childBuf, ">\n"); + + virBufferAdjustIndent(&childBuf, 2); + virBufferAsprintf(&childBuf, + "\n", + cache->size); + + if (cache->line) { + virBufferAsprintf(&childBuf, + "\n", + cache->line); + } + + virBufferAdjustIndent(&childBuf, -2); + virBufferAddLit(&childBuf, "\n"); + } + + virXMLFormatElement(buf, "cell", &attrBuf, &childBuf); } if (def->ninterconnects) {