NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't update dom->persistent without lock held

Browse Source 
virDomainObjListLoadAllConfigs sets dom->persistent after
having released its lock on the domain object. This exposes
a possible race condition.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrange 2013-10-28 14:07:26 +00:00
parent d70840f68d
commit b260a77e34
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/conf/domain_conf.c
View File

@ -17373,9 +17373,9 @@ virDomainObjListLoadAllConfigs(virDomainObjListPtr doms,
notify, notify,
opaque); opaque);
if (dom) { if (dom) {
virObjectUnlock(dom);
if (!liveStatus) if (!liveStatus)
dom->persistent = 1; dom->persistent = 1;
virObjectUnlock(dom);
} }
} }