From c00643f86f8a27643a062c3c881469ff56f34f00 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Sun, 17 Dec 2017 12:41:03 -0500 Subject: [PATCH] conf: Need to unlock pools on object allocation failure The RW pool could be left locked if allocation fails. --- src/conf/virstorageobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 49fe24b28c..19903b6c51 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -748,7 +748,7 @@ virStoragePoolObjAssignDef(virStoragePoolObjListPtr pools, } if (!(obj = virStoragePoolObjNew())) - return NULL; + goto error; virUUIDFormat(def->uuid, uuidstr); if (virHashAddEntry(pools->objs, uuidstr, obj) < 0)