NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

conf: don't bother setting pointers to NULL in vir*Free() functions

Browse Source 
The memory containing the pointer is going to be freed momentarily anyway.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Laine Stump 2021-01-26 21:23:06 -05:00
parent eb8f62ce88
commit c2e47fb334
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/conf/domain_conf.c
View File

@ -1908,7 +1908,6 @@ virDomainVcpuDefFree(virDomainVcpuDefPtr info)
return; return;
virBitmapFree(info->cpumask); virBitmapFree(info->cpumask);
info->cpumask = NULL;
virObjectUnref(info->privateData); virObjectUnref(info->privateData);
VIR_FREE(info); VIR_FREE(info);
} }
@ -2474,7 +2473,6 @@ virDomainNetDefFree(virDomainNetDefPtr def)
switch (def->type) { switch (def->type) {
case VIR_DOMAIN_NET_TYPE_VHOSTUSER: case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
virObjectUnref(def->data.vhostuser); virObjectUnref(def->data.vhostuser);
def->data.vhostuser = NULL;
break; break;
case VIR_DOMAIN_NET_TYPE_VDPA: case VIR_DOMAIN_NET_TYPE_VDPA:
@ -2493,7 +2491,6 @@ virDomainNetDefFree(virDomainNetDefPtr def)
g_free(def->data.network.name); g_free(def->data.network.name);
g_free(def->data.network.portgroup); g_free(def->data.network.portgroup);
virDomainActualNetDefFree(def->data.network.actual); virDomainActualNetDefFree(def->data.network.actual);
def->data.network.actual = NULL;
break; break;
case VIR_DOMAIN_NET_TYPE_BRIDGE: case VIR_DOMAIN_NET_TYPE_BRIDGE:
@ -2537,10 +2534,8 @@ virDomainNetDefFree(virDomainNetDefPtr def)
g_free(def->filter); g_free(def->filter);
virHashFree(def->filterparams); virHashFree(def->filterparams);
def->filterparams = NULL;
virNetDevBandwidthFree(def->bandwidth); virNetDevBandwidthFree(def->bandwidth);
def->bandwidth = NULL;
virNetDevVlanClear(&def->vlan); virNetDevVlanClear(&def->vlan);
virObjectUnref(def->privateData); virObjectUnref(def->privateData);

1
src/conf/node_device_conf.c
View File

@ -2422,7 +2422,6 @@ virNodeDevCapsDefFree(virNodeDevCapsDefPtr caps)
VIR_FREE(data->net.ifname); VIR_FREE(data->net.ifname);
VIR_FREE(data->net.address); VIR_FREE(data->net.address);
virBitmapFree(data->net.features); virBitmapFree(data->net.features);
data->net.features = NULL;
break; break;
case VIR_NODE_DEV_CAP_SCSI_HOST: case VIR_NODE_DEV_CAP_SCSI_HOST:
VIR_FREE(data->scsi_host.wwnn); VIR_FREE(data->scsi_host.wwnn);