From c441f60be8877e1c147ac1c88c9a82cc57a9b16c Mon Sep 17 00:00:00 2001 From: Daniel Henrique Barboza Date: Fri, 13 Nov 2020 14:46:49 -0300 Subject: [PATCH] qemu_driver.c: do not redefine 'event' in qemuDomainDefineXMLFlags() A bad merge while rebasing 74b2834333a caused the @event variable to be defined twice, inside the 'cleanup' label, causing coverity errors. This code was originally moved outside of the label by commit 773c7c43611a. Delete the unintended code in the 'cleanup' label. Fixes: 74b2834333ab3bf500f870e0a6d4e8309379d96a Reported-by: John Ferlan Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_driver.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 78ccf96df5..ac38edf009 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6748,15 +6748,6 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, } } - event = virDomainEventLifecycleNewFromObj(vm, - VIR_DOMAIN_EVENT_DEFINED, - !oldDef ? - VIR_DOMAIN_EVENT_DEFINED_ADDED : - VIR_DOMAIN_EVENT_DEFINED_UPDATED); - - VIR_INFO("Creating domain '%s'", vm->def->name); - dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id); - virDomainObjEndAPI(&vm); virObjectEventStateQueue(driver->domainEventState, event); return dom;