NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

vbox: Drop @networkName from UIDHCPServer::Start()

Browse Source 
The @networkName argument of UIDHCPServer::Start() callback is
unused. Drop it and also its propagation from parent functions.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Michal Privoznik 2023-01-22 13:12:27 +01:00
parent aad22bea70
commit c4b19a0e40
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/vbox/vbox_network.c
View File

@ -499,7 +499,6 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start,
if (start) if (start)
gVBoxAPI.UIDHCPServer.Start(dhcpServer, gVBoxAPI.UIDHCPServer.Start(dhcpServer,
networkNameUtf16, networkNameUtf16,
networkInterfaceNameUtf16,
trunkTypeUtf16); trunkTypeUtf16);
VBOX_UTF16_FREE(ipAddressUtf16); VBOX_UTF16_FREE(ipAddressUtf16);
@ -740,7 +739,6 @@ static int vboxNetworkCreate(virNetworkPtr network)
gVBoxAPI.UIDHCPServer.Start(dhcpServer, gVBoxAPI.UIDHCPServer.Start(dhcpServer,
networkNameUtf16, networkNameUtf16,
networkInterfaceNameUtf16,
trunkTypeUtf16); trunkTypeUtf16);
VBOX_UTF16_FREE(trunkTypeUtf16); VBOX_UTF16_FREE(trunkTypeUtf16);

2
src/vbox/vbox_tmpl.c
View File

@ -2088,7 +2088,7 @@ _dhcpServerSetConfiguration(IDHCPServer *dhcpServer, PRUnichar *IPAddress,
} }
static nsresult static nsresult
_dhcpServerStart(IDHCPServer *dhcpServer, PRUnichar *networkName G_GNUC_UNUSED, _dhcpServerStart(IDHCPServer *dhcpServer,
PRUnichar *trunkName, PRUnichar *trunkType) PRUnichar *trunkName, PRUnichar *trunkType)
{ {
return dhcpServer->vtbl->Start(dhcpServer, return dhcpServer->vtbl->Start(dhcpServer,

2
src/vbox/vbox_uniformed_api.h
View File

@ -482,7 +482,7 @@ typedef struct {
nsresult (*SetConfiguration)(IDHCPServer *dhcpServer, PRUnichar *IPAddress, nsresult (*SetConfiguration)(IDHCPServer *dhcpServer, PRUnichar *IPAddress,
PRUnichar *networkMask, PRUnichar *FromIPAddress, PRUnichar *networkMask, PRUnichar *FromIPAddress,
PRUnichar *ToIPAddress); PRUnichar *ToIPAddress);
nsresult (*Start)(IDHCPServer *dhcpServer, PRUnichar *networkName, nsresult (*Start)(IDHCPServer *dhcpServer,
PRUnichar *trunkName, PRUnichar *trunkType); PRUnichar *trunkName, PRUnichar *trunkType);
nsresult (*Stop)(IDHCPServer *dhcpServer); nsresult (*Stop)(IDHCPServer *dhcpServer);
} vboxUniformedIDHCPServer; } vboxUniformedIDHCPServer;