NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2026-08-14 07:04:43 -05:00
Code Issues Packages Projects Releases Wiki Activity

lib: Drop internal virXXXPtr typedefs

Browse Source 
Historically, we declared pointer type to our types:

  typedef struct _virXXX virXXX;
  typedef virXXX *virXXXPtr;

But usefulness of such declaration is questionable, at best.
Unfortunately, we can't drop every such declaration - we have to
carry some over, because they are part of public API (e.g.
virDomainPtr). But for internal types - we can do drop them and
use what every other C project uses 'virXXX *'.

This change was generated by a very ugly shell script that
generated sed script which was then called over each file in the
repository. For the shell script refer to the cover letter:

https://listman.redhat.com/archives/libvir-list/2021-March/msg00537.html

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Michal Privoznik
2021-04-13 17:00:38 +02:00
parent c21f066d61
commit c8238579fb
734 changed files with 29338 additions and 30231 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tools/virsh-snapshot.c
+12 -13
View File
@@ -216,7 +216,7 @@ cmdSnapshotCreate(vshControl *ctl, const vshCmd *cmd)
* "snapshot-create-as" command
*/
static int
virshParseSnapshotMemspec(vshControl *ctl, virBufferPtr buf, const char *str)
virshParseSnapshotMemspec(vshControl *ctl, virBuffer *buf, const char *str)
{
int ret = -1;
const char *snapshot = NULL;
@@ -256,7 +256,7 @@ virshParseSnapshotMemspec(vshControl *ctl, virBufferPtr buf, const char *str)
}
static int
virshParseSnapshotDiskspec(vshControl *ctl, virBufferPtr buf, const char *str)
virshParseSnapshotDiskspec(vshControl *ctl, virBuffer *buf, const char *str)
{
int ret = -1;
const char *name = NULL;
@@ -738,7 +738,7 @@ virshGetSnapshotParent(vshControl *ctl, virDomainSnapshotPtr snapshot,
xmlDocPtr xmldoc = NULL;
xmlXPathContextPtr ctxt = NULL;
int ret = -1;
virshControlPtr priv = ctl->privData;
virshControl *priv = ctl->privData;
*parent_name = NULL;
@@ -883,7 +883,7 @@ cmdSnapshotInfo(vshControl *ctl, const vshCmd *cmd)
unsigned int flags;
int current;
int metadata;
virshControlPtr priv = ctl->privData;
virshControl *priv = ctl->privData;
dom = virshCommandOptDomain(ctl, cmd, NULL);
if (dom == NULL)
@@ -1020,10 +1020,9 @@ struct virshSnapshotList {
struct virshSnap *snaps;
int nsnaps;
};
typedef struct virshSnapshotList *virshSnapshotListPtr;
static void
virshSnapshotListFree(virshSnapshotListPtr snaplist)
virshSnapshotListFree(struct virshSnapshotList *snaplist)
{
size_t i;
@@ -1058,7 +1057,7 @@ virshSnapSorter(const void *a, const void *b)
* list is limited to descendants of the given snapshot. If FLAGS is
* given, the list is filtered. If TREE is specified, then all but
* FROM or the roots will also have parent information. */
static virshSnapshotListPtr
static struct virshSnapshotList *
virshSnapshotListCollect(vshControl *ctl, virDomainPtr dom,
virDomainSnapshotPtr from,
unsigned int orig_flags, bool tree)
@@ -1069,14 +1068,14 @@ virshSnapshotListCollect(vshControl *ctl, virDomainPtr dom,
bool descendants = false;
bool roots = false;
virDomainSnapshotPtr *snaps;
virshSnapshotListPtr snaplist = g_new0(struct virshSnapshotList, 1);
virshSnapshotListPtr ret = NULL;
struct virshSnapshotList *snaplist = g_new0(struct virshSnapshotList, 1);
struct virshSnapshotList *ret = NULL;
const char *fromname = NULL;
int start_index = -1;
int deleted = 0;
bool filter_fallback = false;
unsigned int flags = orig_flags;
virshControlPtr priv = ctl->privData;
virshControl *priv = ctl->privData;
/* Try the interface available in 0.9.13 and newer. */
if (!priv->useSnapshotOld) {
@@ -1388,7 +1387,7 @@ virshSnapshotListCollect(vshControl *ctl, virDomainPtr dom,
static const char *
virshSnapshotListLookup(int id, bool parent, void *opaque)
{
virshSnapshotListPtr snaplist = opaque;
struct virshSnapshotList *snaplist = opaque;
if (parent)
return snaplist->snaps[id].parent;
return virDomainSnapshotGetName(snaplist->snaps[id].snap);
@@ -1502,8 +1501,8 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
const char *from_snap = NULL;
char *parent_snap = NULL;
virDomainSnapshotPtr start = NULL;
virshSnapshotListPtr snaplist = NULL;
vshTablePtr table = NULL;
struct virshSnapshotList *snaplist = NULL;
vshTable *table = NULL;
VSH_EXCLUSIVE_OPTIONS_VAR(tree, name);
VSH_EXCLUSIVE_OPTIONS_VAR(parent, roots);