NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix check for errors in device_add command in QEMU text monitor

Browse Source 
Any output at all from device_add indicates an error in the
command execution. Thus it needs to check for reply != ""

* src/qemu/qemu_monitor_text.c: Fix reply check for errors
  to treat any output as an error
This commit is contained in:
Daniel P. Berrange 2010-05-28 12:18:09 +01:00
parent 345ff369e5
commit c833efd35b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/qemu/qemu_monitor_text.c
View File

@ -2319,11 +2319,11 @@ int qemuMonitorTextAddDevice(qemuMonitorPtr mon,
goto cleanup; goto cleanup;
} }
/* If the command failed qemu prints: /* If the command succeeds, no output is sent. So
* Could not add ... */ * any non-empty string shows an error */
if (strstr(reply, "Could not add ")) { if (STRNEQ(reply, "")) {
qemuReportError(VIR_ERR_OPERATION_FAILED, qemuReportError(VIR_ERR_OPERATION_FAILED,
_("adding %s device failed"), devicestr); _("adding %s device failed: %s"), devicestr, reply);
goto cleanup; goto cleanup;
} }