From c93bf6164799946c6218088d665c01b0081c724a Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 19 Oct 2021 14:48:16 +0200 Subject: [PATCH] qemuMonitorJSONBlockStatsUpdateCapacityOne: Refactor cleanup Use automatic memory clearing for the temporary variable and remove the cleanup section. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/qemu/qemu_monitor_json.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index af6e918e06..e4f4dba79a 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2631,13 +2631,12 @@ qemuMonitorJSONBlockStatsUpdateCapacityOne(virJSONValue *image, GHashTable *stats, bool backingChain) { - int ret = -1; - char *entry_name = qemuDomainStorageAlias(dev_name, depth); + g_autofree char *entry_name = qemuDomainStorageAlias(dev_name, depth); virJSONValue *backing; if (qemuMonitorJSONBlockStatsUpdateCapacityData(image, entry_name, stats, NULL) < 0) - goto cleanup; + return -1; if (backingChain && (backing = virJSONValueObjectGetObject(image, "backing-image")) && @@ -2646,12 +2645,9 @@ qemuMonitorJSONBlockStatsUpdateCapacityOne(virJSONValue *image, depth + 1, stats, true) < 0) - goto cleanup; + return -1; - ret = 0; - cleanup: - VIR_FREE(entry_name); - return ret; + return 0; }