From caa4f0dd826da6aa33c08fe5af5ba29e8015d67b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Date: Wed, 5 Jun 2019 12:30:59 +0200 Subject: [PATCH] device-conf: removed unneeded virDomainDeviceInfoCopy() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Marc-André Lureau Reviewed-by: Ján Tomko Signed-off-by: Ján Tomko --- src/conf/device_conf.c | 21 --------------------- src/conf/device_conf.h | 2 -- src/libvirt_private.syms | 1 - 3 files changed, 24 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 2f82bdc2a7..b28f30dfc5 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -86,27 +86,6 @@ virZPCIDeviceAddressParseXML(xmlNodePtr node, return ret; } -int -virDomainDeviceInfoCopy(virDomainDeviceInfoPtr dst, - virDomainDeviceInfoPtr src) -{ - /* Assume that dst is already cleared */ - - /* first a shallow copy of *everything* */ - *dst = *src; - - /* then copy whatever's left */ - dst->alias = NULL; - dst->romfile = NULL; - dst->loadparm = NULL; - - if (VIR_STRDUP(dst->alias, src->alias) < 0 || - VIR_STRDUP(dst->romfile, src->romfile) < 0 || - VIR_STRDUP(dst->loadparm, src->loadparm) < 0) - return -1; - return 0; -} - void virDomainDeviceInfoClear(virDomainDeviceInfoPtr info) { diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index 06f7f365ad..d0854925e3 100644 --- a/src/conf/device_conf.h +++ b/src/conf/device_conf.h @@ -181,8 +181,6 @@ struct _virDomainDeviceInfo { bool isolationGroupLocked; }; -int virDomainDeviceInfoCopy(virDomainDeviceInfoPtr dst, - virDomainDeviceInfoPtr src); void virDomainDeviceInfoClear(virDomainDeviceInfoPtr info); void virDomainDeviceInfoFree(virDomainDeviceInfoPtr info); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 48df6bce08..34937adc5d 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -107,7 +107,6 @@ virDomainDeviceCCWAddressIsValid; virDomainDeviceCCWAddressParseXML; virDomainDeviceDriveAddressParseXML; virDomainDeviceInfoAddressIsEqual; -virDomainDeviceInfoCopy; virDomainDeviceSpaprVioAddressParseXML; virDomainDeviceUSBAddressParseXML; virDomainDeviceVirtioSerialAddressParseXML;