NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

util: string: Introduce virStringEncodeBase64

Browse Source 
Add a new helper that sanitizes error semantics of base64_encode_alloc.
This commit is contained in:
Peter Krempa
2016-05-13 13:15:15 +02:00
parent 1d632c3924
commit cb2e3e50ee
7 changed files with 40 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tools/virsh-secret.c
View File

@@ -32,6 +32,7 @@
#include "viralloc.h"
#include "virfile.h"
#include "virutil.h"
#include "virstring.h"
#include "conf/secret_conf.h"
static virSecretPtr
@@ -265,20 +266,15 @@ cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd)
if (value == NULL)
goto cleanup;
base64_encode_alloc((char *)value, value_size, &base64);
memset(value, 0, value_size);
VIR_FREE(value);
if (base64 == NULL) {
vshError(ctl, "%s", _("Failed to allocate memory"));
if (!(base64 = virStringEncodeBase64(value, value_size)))
goto cleanup;
}
vshPrint(ctl, "%s", base64);
memset(base64, 0, strlen(base64));
VIR_FREE(base64);
ret = true;
cleanup:
VIR_DISPOSE_N(value, value_size);
VIR_DISPOSE_STRING(base64);
virSecretFree(secret);
return ret;
}