NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix check for -Wformat-security which depends on -Wformat

Browse Source
This commit is contained in:
Daniel P. Berrange 2009-04-28 10:55:45 +00:00
parent 9cae1d5ed6
commit cb4a6614fa
3 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ChangeLog
View File

@ -1,3 +1,10 @@
Tue Apr 28 11:54:22 BST 2009 Daniel P. Berrange <berrange@redhat.com>
Fix check for -Wformat-security which depends on -Wformat
* m4/compiler-flags.m4: Set previously verified compiler flags
when checking new flags
* srv/virsh.c: Fix three non-critical format string bugs
Fri Apr 24 15:55:56 CEST 2009 Daniel Veillard <veillard@redhat.com> Fri Apr 24 15:55:56 CEST 2009 Daniel Veillard <veillard@redhat.com>
* NEWS configure.in libvirt.spec.in docs/*: release of 0.6.3 * NEWS configure.in libvirt.spec.in docs/*: release of 0.6.3

10
m4/compiler-flags.m4
View File

@ -24,7 +24,15 @@ AC_DEFUN([gl_COMPILER_FLAGS],
[AC_MSG_CHECKING(whether compiler accepts $1) [AC_MSG_CHECKING(whether compiler accepts $1)
AC_SUBST(COMPILER_FLAGS) AC_SUBST(COMPILER_FLAGS)
ac_save_CFLAGS="$CFLAGS" ac_save_CFLAGS="$CFLAGS"
CFLAGS="$CFLAGS $1" dnl Some flags are dependant, so we set all previously checked
dnl flags when testing. Except for -Werror which we have to
dnl check on its own, because some of our compiler flags cause
dnl warnings from the autoconf test program!
if test "$1" = "-Werror" ; then
CFLAGS="$CFLAGS $1"
else
CFLAGS="$CFLAGS $COMPILER_FLAGS $1"
fi
AC_TRY_LINK([], [], has_option=yes, has_option=no,) AC_TRY_LINK([], [], has_option=yes, has_option=no,)
echo 'int x;' >conftest.c echo 'int x;' >conftest.c
$CC $CFLAGS -c conftest.c 2>conftest.err $CC $CFLAGS -c conftest.c 2>conftest.err

6
src/virsh.c
View File

@ -4463,7 +4463,7 @@ cmdNodeListDevicesPrint(vshControl *ctl,
} }
/* Print this device */ /* Print this device */
vshPrint(ctl, indentBuf); vshPrint(ctl, "%s", indentBuf);
vshPrint(ctl, "%s\n", devices[devid]); vshPrint(ctl, "%s\n", devices[devid]);
@ -4487,7 +4487,7 @@ cmdNodeListDevicesPrint(vshControl *ctl,
/* If there is a child device, then print another blank line */ /* If there is a child device, then print another blank line */
if (nextlastdev != -1) { if (nextlastdev != -1) {
vshPrint(ctl, indentBuf); vshPrint(ctl, "%s", indentBuf);
vshPrint(ctl, " |\n"); vshPrint(ctl, " |\n");
} }
@ -4511,7 +4511,7 @@ cmdNodeListDevicesPrint(vshControl *ctl,
/* If there was no child device, and we're the last in /* If there was no child device, and we're the last in
* a list of devices, then print another blank line */ * a list of devices, then print another blank line */
if (nextlastdev == -1 && devid == lastdev) { if (nextlastdev == -1 && devid == lastdev) {
vshPrint(ctl, indentBuf); vshPrint(ctl, "%s", indentBuf);
vshPrint(ctl, "\n"); vshPrint(ctl, "\n");
} }
} }