mirror of
https://github.com/libvirt/libvirt.git
synced 2025-02-25 18:55:26 -06:00
virDomainAuthorizedSSHKeysSet: Use uint for @nkeys
When introducing the API I've mistakenly used 'int' type for @nkeys argument which does nothing more than tells the API how many items there are in @keys array. Obviously, negative values are not expected and therefore 'unsigned int' should have been used. Reported-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
@@ -5115,7 +5115,7 @@ typedef enum {
|
|||||||
int virDomainAuthorizedSSHKeysSet(virDomainPtr domain,
|
int virDomainAuthorizedSSHKeysSet(virDomainPtr domain,
|
||||||
const char *user,
|
const char *user,
|
||||||
const char **keys,
|
const char **keys,
|
||||||
int nkeys,
|
unsigned int nkeys,
|
||||||
unsigned int flags);
|
unsigned int flags);
|
||||||
|
|
||||||
#endif /* LIBVIRT_DOMAIN_H */
|
#endif /* LIBVIRT_DOMAIN_H */
|
||||||
|
|||||||
@@ -1397,7 +1397,7 @@ typedef int
|
|||||||
(*virDrvDomainAuthorizedSSHKeysSet)(virDomainPtr domain,
|
(*virDrvDomainAuthorizedSSHKeysSet)(virDomainPtr domain,
|
||||||
const char *user,
|
const char *user,
|
||||||
const char **keys,
|
const char **keys,
|
||||||
int nkeys,
|
unsigned int nkeys,
|
||||||
unsigned int flags);
|
unsigned int flags);
|
||||||
|
|
||||||
typedef struct _virHypervisorDriver virHypervisorDriver;
|
typedef struct _virHypervisorDriver virHypervisorDriver;
|
||||||
|
|||||||
@@ -12853,12 +12853,12 @@ int
|
|||||||
virDomainAuthorizedSSHKeysSet(virDomainPtr domain,
|
virDomainAuthorizedSSHKeysSet(virDomainPtr domain,
|
||||||
const char *user,
|
const char *user,
|
||||||
const char **keys,
|
const char **keys,
|
||||||
int nkeys,
|
unsigned int nkeys,
|
||||||
unsigned int flags)
|
unsigned int flags)
|
||||||
{
|
{
|
||||||
virConnectPtr conn;
|
virConnectPtr conn;
|
||||||
|
|
||||||
VIR_DOMAIN_DEBUG(domain, "user=%s, keys=%p, nkeys=%d, flags=0x%x",
|
VIR_DOMAIN_DEBUG(domain, "user=%s, keys=%p, nkeys=%u, flags=0x%x",
|
||||||
user, keys, nkeys, flags);
|
user, keys, nkeys, flags);
|
||||||
|
|
||||||
virResetLastError();
|
virResetLastError();
|
||||||
|
|||||||
@@ -20134,7 +20134,7 @@ static int
|
|||||||
qemuDomainAuthorizedSSHKeysSet(virDomainPtr dom,
|
qemuDomainAuthorizedSSHKeysSet(virDomainPtr dom,
|
||||||
const char *user,
|
const char *user,
|
||||||
const char **keys,
|
const char **keys,
|
||||||
int nkeys,
|
unsigned int nkeys,
|
||||||
unsigned int flags)
|
unsigned int flags)
|
||||||
{
|
{
|
||||||
virQEMUDriverPtr driver = dom->conn->privateData;
|
virQEMUDriverPtr driver = dom->conn->privateData;
|
||||||
|
|||||||
@@ -8066,7 +8066,7 @@ static int
|
|||||||
remoteDomainAuthorizedSSHKeysSet(virDomainPtr domain,
|
remoteDomainAuthorizedSSHKeysSet(virDomainPtr domain,
|
||||||
const char *user,
|
const char *user,
|
||||||
const char **keys,
|
const char **keys,
|
||||||
int nkeys,
|
unsigned int nkeys,
|
||||||
unsigned int flags)
|
unsigned int flags)
|
||||||
{
|
{
|
||||||
int rv = -1;
|
int rv = -1;
|
||||||
|
|||||||
Reference in New Issue
Block a user