NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

qemuSnapshotFSFreeze: Don't return -2

Browse Source 
The -2 value is misleading because if 'qemuAgentFSFreeze' fails it
doesn't necessarily mean that the command was sent to the agent.

Since callers don't care about the -2 value specifically, remove it.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2021-02-15 18:12:29 +01:00
parent ee91c82533
commit ce8670ef46
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/qemu/qemu_snapshot.c
View File

@ -119,9 +119,6 @@ qemuSnapshotCountExternal(void *payload,
} }
/* Return -1 if request is not sent to agent due to misconfig, -2 if request
* is sent but failed, and number of frozen filesystems on success. If -2 is
* returned, FSThaw should be called revert the quiesced status. */
int int
qemuSnapshotFSFreeze(virDomainObjPtr vm, qemuSnapshotFSFreeze(virDomainObjPtr vm,
const char **mountpoints, const char **mountpoints,
@ -136,7 +133,7 @@ qemuSnapshotFSFreeze(virDomainObjPtr vm,
agent = qemuDomainObjEnterAgent(vm); agent = qemuDomainObjEnterAgent(vm);
frozen = qemuAgentFSFreeze(agent, mountpoints, nmountpoints); frozen = qemuAgentFSFreeze(agent, mountpoints, nmountpoints);
qemuDomainObjExitAgent(vm, agent); qemuDomainObjExitAgent(vm, agent);
return frozen < 0 ? -2 : frozen; return frozen;
} }