From cf53aafa7097fc7ff6f187c252cf9e9f6bcf4249 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 2 Apr 2026 15:41:24 +0200 Subject: [PATCH] qemu: dump: Move 'virCheckFlags' to top level functions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Move the flag check to the top level to allow programatic introspection of supported flags. Extract the supported flags as a macro so that they can be reused in both coredump APIs. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_driver.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 38705ef161..6ba2ba5a5e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3234,6 +3234,12 @@ doCoreDump(virQEMUDriver *driver, return ret; } +#define QEMU_DOMAIN_CORE_DUMP_FLAGS \ + VIR_DUMP_CRASH | \ + VIR_DUMP_BYPASS_CACHE | \ + VIR_DUMP_RESET | \ + VIR_DUMP_MEMORY_ONLY + static int qemuDomainCoreDumpWithFormat(virDomainPtr dom, @@ -3248,9 +3254,7 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom, int ret = -1; virObjectEvent *event = NULL; - virCheckFlags(VIR_DUMP_CRASH | - VIR_DUMP_BYPASS_CACHE | VIR_DUMP_RESET | - VIR_DUMP_MEMORY_ONLY, -1); + virCheckFlags(QEMU_DOMAIN_CORE_DUMP_FLAGS, -1); if (!(vm = qemuDomainObjFromDomain(dom))) return -1; @@ -3343,6 +3347,8 @@ qemuDomainCoreDump(virDomainPtr dom, const char *path, unsigned int flags) { + virCheckFlags(QEMU_DOMAIN_CORE_DUMP_FLAGS, -1); + return qemuDomainCoreDumpWithFormat(dom, path, VIR_DOMAIN_CORE_DUMP_FORMAT_RAW, flags);