NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

m4: enable -fstack-protector-strong on mingw

Browse Source 
Historically we avoided -fstack-protector* since it resulted in a broken
build on Mingw. In GCC 10 in Fedora though, we have the opposite problem,
getting a broken build if we don't enable one of the -fstack-protector*
options. This also works in GCC 9, so we don't need to worry about the
old brokeness which evidentally got fixed at some time without noticing.

Reviewed-by: Laine Stump <laine@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2020-07-22 17:29:19 +01:00
parent 9ee8c4e96a
commit d0c64fc281
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
m4/virt-compile-warnings.m4
View File

@ -169,13 +169,11 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
gl_WARN_ADD([-Wframe-larger-than=262144], [RELAXED_FRAME_LIMIT_CFLAGS]) gl_WARN_ADD([-Wframe-larger-than=262144], [RELAXED_FRAME_LIMIT_CFLAGS])
# Extra special flags # Extra special flags
dnl -fstack-protector stuff passes gl_WARN_ADD with gcc
dnl on Mingw32, but fails when actually used
case $host in case $host in
aarch64-*-*) aarch64-*-*)
dnl "error: -fstack-protector not supported for this target [-Werror]" dnl "error: -fstack-protector not supported for this target [-Werror]"
;; ;;
*-*-linux*) *-*-linux* | *-*-mingw*)
dnl Prefer -fstack-protector-strong if it's available. dnl Prefer -fstack-protector-strong if it's available.
dnl There doesn't seem to be great overhead in adding dnl There doesn't seem to be great overhead in adding
dnl -fstack-protector-all instead of -fstack-protector. dnl -fstack-protector-all instead of -fstack-protector.