From d64d5ccb06428227f93f7bb56b0983914d368dd7 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Mon, 22 Jan 2018 12:37:31 +0000 Subject: [PATCH] docs: document requirement to provide Signed-off-by lines for DCO Document that contributors are required to assert compliance with the Developers Certification of Origin 1.1, by providing Signed-off-by tags for all commit messages. The DCO is formally stating what we have long implicitly expected of contributors in terms of their legal rights to make the contribution. This puts the project in a stronger position should any questions around contributions be raised going forward in the future. Signed-off-by: Daniel P. Berrange --- docs/hacking.html.in | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 6cadfb8343..bb5047d99e 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -108,12 +108,19 @@ of the bug number is useful; but also summarize the issue rather than making all readers follow the link. You can use 'git shortlog -30' to get an idea of typical summary lines. - Libvirt does not currently attach any meaning to - Signed-off-by: lines, so it is up to you if you want to - include or omit them in the commit message.

+
  • Contributors to libvirt projects must + assert that they are in compliance with the + Developer + Certificate of Origin 1.1. This is achieved by adding + a "Signed-off-by" line containing the contributor's name + and e-mail to every commit message. The presence + of this line attests that the contributor has read the + above lined DCO and agrees with its statements. +

  • +
  • Split large changes into a series of smaller patches, self-contained if possible, with an explanation of each patch and an explanation of how the sequence of patches fits