From d80d0d5d4052f245fc2827d241c0e9bab92e5e07 Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Tue, 4 Jun 2013 16:00:46 -0400 Subject: [PATCH] syntax: virPCIDeviceFree is also a NOP for NULL args add it to the syntax-check list and fix the one offending caller. --- cfg.mk | 1 + src/util/virpci.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cfg.mk b/cfg.mk index c093bf2483..bbe84b3174 100644 --- a/cfg.mk +++ b/cfg.mk @@ -165,6 +165,7 @@ useless_free_options = \ --name=virNodeDeviceObjFree \ --name=virObjectUnref \ --name=virObjectFreeCallback \ + --name=virPCIDeviceFree \ --name=virSecretDefFree \ --name=virStorageEncryptionFree \ --name=virStorageEncryptionSecretFree \ diff --git a/src/util/virpci.c b/src/util/virpci.c index 1346ec175e..89c1eea4cb 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -1671,8 +1671,7 @@ virPCIDeviceListDel(virPCIDeviceListPtr list, virPCIDevicePtr dev) { virPCIDevicePtr ret = virPCIDeviceListSteal(list, dev); - if (ret) - virPCIDeviceFree(ret); + virPCIDeviceFree(ret); } int