From d9536f5cffa8d2402ac5f1a5a88919c68fd917bb Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 11 Jun 2019 13:58:29 +0200 Subject: [PATCH] qemu: process: Report better error when virtlogd connection fails When connecting to virtlogd fails e.g. due to wrong libvirtd selinux process label we'd report an utterly useless error message: $ virsh start upstream error: Failed to start domain upstream error: Cannot recv data: Connection reset by peer Use virLastErrorPrefixMessage in the correct place to give a better sense of what's going on: $ virsh start upstream error: Failed to start domain upstream error: can't connect to virtlogd: Cannot recv data: Connection reset by peer Signed-off-by: Peter Krempa ACKed-by: Michal Privoznik --- src/qemu/qemu_process.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c9f8a0f311..86cfeeb6f0 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6641,8 +6641,10 @@ qemuProcessLaunch(virConnectPtr conn, VIR_DEBUG("Creating domain log file"); if (!(logCtxt = qemuDomainLogContextNew(driver, vm, - QEMU_DOMAIN_LOG_CONTEXT_MODE_START))) + QEMU_DOMAIN_LOG_CONTEXT_MODE_START))) { + virLastErrorPrefixMessage("%s", _("can't connect to virtlogd")); goto cleanup; + } logfile = qemuDomainLogContextGetWriteFD(logCtxt); if (qemuProcessGenID(vm, flags) < 0)