NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

domain_conf: Resolve Coverity DEADCODE

Browse Source 
A bunch of a useless warnings brought on by our own doing.
This commit is contained in:
John Ferlan 2014-08-27 16:15:06 -04:00
parent ee8b6245e9
commit dad6ef18aa
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/conf/domain_conf.c
View File

@ -2804,6 +2804,8 @@ virDomainDeviceInfoIterateInternal(virDomainDefPtr def,
return -1; return -1;
} }
/* Coverity is not very happy with this - all dead_error_condition */
#if !STATIC_ANALYSIS
/* This switch statement is here to trigger compiler warning when adding /* This switch statement is here to trigger compiler warning when adding
* a new device type. When you are adding a new field to the switch you * a new device type. When you are adding a new field to the switch you
* also have to add an iteration statement above. Otherwise the switch * also have to add an iteration statement above. Otherwise the switch
@ -2833,6 +2835,7 @@ virDomainDeviceInfoIterateInternal(virDomainDefPtr def,
case VIR_DOMAIN_DEVICE_RNG: case VIR_DOMAIN_DEVICE_RNG:
break; break;
} }
#endif
return 0; return 0;
} }
@ -12263,6 +12266,7 @@ virDomainDefParseXML(xmlDocPtr xml,
ctxt->node = node; ctxt->node = node;
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_FEATURE_LAST: case VIR_DOMAIN_FEATURE_LAST:
break; break;
} }
@ -12346,6 +12350,7 @@ virDomainDefParseXML(xmlDocPtr xml,
def->hyperv_features[feature] = value; def->hyperv_features[feature] = value;
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_HYPERV_LAST: case VIR_DOMAIN_HYPERV_LAST:
break; break;
} }
@ -12394,6 +12399,7 @@ virDomainDefParseXML(xmlDocPtr xml,
def->kvm_features[feature] = value; def->kvm_features[feature] = value;
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_KVM_LAST: case VIR_DOMAIN_KVM_LAST:
break; break;
} }
@ -14406,6 +14412,7 @@ virDomainDefFeaturesCheckABIStability(virDomainDefPtr src,
} }
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_HYPERV_LAST: case VIR_DOMAIN_HYPERV_LAST:
break; break;
} }
@ -14429,6 +14436,7 @@ virDomainDefFeaturesCheckABIStability(virDomainDefPtr src,
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_KVM_LAST: case VIR_DOMAIN_KVM_LAST:
break; break;
} }
@ -18253,6 +18261,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
virBufferAddLit(buf, "/>\n"); virBufferAddLit(buf, "/>\n");
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_HYPERV_LAST: case VIR_DOMAIN_HYPERV_LAST:
break; break;
} }
@ -18277,6 +18286,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
def->kvm_features[j])); def->kvm_features[j]));
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_KVM_LAST: case VIR_DOMAIN_KVM_LAST:
break; break;
} }
@ -18304,6 +18314,7 @@ virDomainDefFormatInternal(virDomainDefPtr def,
virBufferAddLit(buf, "</capabilities>\n"); virBufferAddLit(buf, "</capabilities>\n");
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_FEATURE_LAST: case VIR_DOMAIN_FEATURE_LAST:
break; break;
} }
@ -20255,6 +20266,7 @@ virDomainObjGetMetadata(virDomainObjPtr vm,
goto cleanup; goto cleanup;
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_METADATA_LAST: case VIR_DOMAIN_METADATA_LAST:
break; break;
} }
@ -20340,6 +20352,7 @@ virDomainDefSetMetadata(virDomainDefPtr def,
} }
break; break;
/* coverity[dead_error_begin] */
case VIR_DOMAIN_METADATA_LAST: case VIR_DOMAIN_METADATA_LAST:
break; break;
} }