NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

vircgroup: Remove virCgroupAddTaskController

Browse Source 
There is no need for this function, both of the checks are done
later by virCgroupGetControllerPath.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Pavel Hrdina 2018-07-19 14:39:43 +02:00
parent f9d18f89f7
commit db868852fd
1 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/util/vircgroup.c
View File

@ -1128,35 +1128,6 @@ virCgroupNew(pid_t pid,
} }
/**
* virCgroupAddTaskController:
*
* @group: The cgroup to add a task to
* @pid: The pid of the task to add
* @controller: The cgroup controller to be operated on
*
* Returns: 0 on success or -1 on error
*/
static int
virCgroupAddTaskController(virCgroupPtr group, pid_t pid, int controller)
{
if (controller < 0 || controller >= VIR_CGROUP_CONTROLLER_LAST) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("Controller %d out of range"), controller);
return -1;
}
if (!group->controllers[controller].mountPoint) {
virReportError(VIR_ERR_INTERNAL_ERROR,
_("Controller '%s' not mounted"),
virCgroupControllerTypeToString(controller));
return -1;
}
return virCgroupSetValueI64(group, controller, "tasks", pid);
}
static int static int
virCgroupAddTaskInternal(virCgroupPtr group, pid_t pid, bool withSystemd) virCgroupAddTaskInternal(virCgroupPtr group, pid_t pid, bool withSystemd)
{ {
@ -1174,7 +1145,7 @@ virCgroupAddTaskInternal(virCgroupPtr group, pid_t pid, bool withSystemd)
if (i == VIR_CGROUP_CONTROLLER_SYSTEMD && !withSystemd) if (i == VIR_CGROUP_CONTROLLER_SYSTEMD && !withSystemd)
continue; continue;
if (virCgroupAddTaskController(group, pid, i) < 0) if (virCgroupSetValueI64(group, i, "tasks", pid) < 0)
goto cleanup; goto cleanup;
} }