NuKVM/libvirt
3
0
Fork 0
mirror of https://github.com/libvirt/libvirt.git synced 2025-02-25 18:55:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix virsh snapshot-list error reporting

Browse Source 
Noticed that the expected "not supported" error is dropped when
invoking 'virsh snapshot-list dom' on a Xen installation running
the libxl driver

 virsh snapshot-list test
 error: Invalid snapshot: virDomainSnapshotFree

The error is overwritten by a call to virDomainSnapshotFree
in cleanup code within cmdSnapshotList.  Prevent overwritting
the real error by not calling virDomainSnapshotFree with a NULL
virDomainSnapshotPtr.
This commit is contained in:
Jim Fehlig 2013-07-25 14:18:14 -06:00
parent 56b54173ed
commit e3b21cdc31
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/virsh-snapshot.c
View File

@ -1678,7 +1678,8 @@ cleanup:
vshSnapshotListFree(snaplist); vshSnapshotListFree(snaplist);
VIR_FREE(parent_snap); VIR_FREE(parent_snap);
VIR_FREE(state); VIR_FREE(state);
virDomainSnapshotFree(start); if (start)
virDomainSnapshotFree(start);
xmlXPathFreeContext(ctxt); xmlXPathFreeContext(ctxt);
xmlFreeDoc(xml); xmlFreeDoc(xml);
VIR_FREE(doc); VIR_FREE(doc);